Upd4 #138
Merged
Upd4 #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh no, multiple loaders? That could be a root cause of so many checking issues. That's nuts. Excellent find! |
|
I'll kick off a versioned release with this. FYI all this takes is pushing a tag with the matching version number in the form |
|
Thanks! |
knocte
added a commit
to knocte/proj-info
that referenced
this pull request
Mar 22, 2022
This reverts commit 5bc6881.
knocte
added a commit
to knocte/proj-info
that referenced
this pull request
Mar 22, 2022
This reverts commit 5bc6881.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProjectController.LoadProject now returns an Async bool to indicate eventual completion
Fix heisen test Heisen failure on one test #136 by waiting on bool for initial load, then waiting a bit longer in CI for the one remaining case.
ProjectController.LoaderLoop was creating a new agent every time the property was evaluated. This looks like a mistake - either a single
loaderLoopshould be created, orLoaderLoopshould be renamed toCreateLoaderLoop()to indicate this is intended. I'm pretty sure the former is intended.