Fixing 6.0.400 issues #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAngryByrd
force-pushed
the
fixing-6-0-400-issues
branch
3 times, most recently
from
1369b6d
to
2b56932
Compare
TheAngryByrd
force-pushed
the
fixing-6-0-400-issues
branch
2 times, most recently
from
b2c5aba
to
18d8969
Compare
For some reason in 6.0.400, CoreCompile was not getting executed and therfore we couldn't read the FscCommandLineArgs. Hopefully addresses ionide/ionide-vscode-fsharp#1748
TheAngryByrd
force-pushed
the
fixing-6-0-400-issues
branch
from
18d8969
to
e695f6f
Compare
|
You know how fantasy books often depict a wizard, tapping into a source of unknown power, and barely, just barely being able to make it bend to his will but he knows it could kill him at any moment? That's what working with MSBuild is like. |
|
Brilliant! That solution makes sense to me, too. I'll merge this and then look into if this solves the 7.0.100 issues as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason in 6.0.400,
CoreCompilewas not getting executed and theerfore we couldn't read theFscCommandLineArgs. This addsCleanto thedesignTimeBuildTargets.Hopefully addresses ionide/ionide-vscode-fsharp#1748