Skip to content
This repository has been archived by the owner on Dec 2, 2023. It is now read-only.

fix: rooms not created TTL Expired #604

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

fix: rooms not created TTL Expired #604

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e95650f
fix: peers avatar and extraInfo not updating on redis
hariprasath2603 Jan 24, 2022
8c3f17e
fix: SA5011 lint error on room_signal file
hariprasath2603 Jan 25, 2022
5152703
fix: extraInfo and avatar are not reflecting on UpdatePeer and AddPeer
hariprasath2603 Jan 29, 2022
23a56ce
fix: room not created if TTL expires while peers join
hariprasath2603 Feb 10, 2022
6621e9a
Merge branch 'master' of https://github.com/pion/ion into pion-master
hariprasath2603 Feb 17, 2022
d2bcff2
Merge pull request #2 from hariprasath2603/pion-master
hariprasath2603 Feb 17, 2022
3225361
lint error for TTL expired user issue commit
hariprasath2603 Feb 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion apps/room/server/room_signal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,12 @@ func (s *RoomSignalService) Join(in *room.Request_Join, stream room.RoomSignal_S
uid := pinfo.Uid

key := util.GetRedisRoomKey(sid)

resArray:= s.rs.redis.HMGet(key, "sid" )
sidFromRedis:= resArray[0]

// create in redis if room not exist
if sid == "" {
if sid == "" || sidFromRedis =="" {
// store room info
sid = pinfo.Sid
err := s.rs.redis.HMSetTTL(roomRedisExpire, key, "sid", sid, "name", pinfo.DisplayName,
Expand Down