Skip to content
This repository has been archived by the owner on Dec 2, 2023. It is now read-only.

Update CI configs to v0.2.1 #94

Closed
wants to merge 1 commit into from
Closed

Update CI configs to v0.2.1 #94

wants to merge 1 commit into from

Conversation

pionbot
Copy link
Contributor

@pionbot pionbot commented Mar 30, 2020

Update lint scripts and CI configs.

Update lint scripts and CI configs.
@Sean-Der
Copy link
Contributor

@adwpc @cloudwebrtc I am going to work on fixing linting issues, if you disagree we can disable this! I don't own Ion so I don't want to make any of the decisions, but some of these are valid errors.

pkg/discovery/node.go:14:2: `name` is unused (structcheck)
        name string
        ^
pkg/rtc/router.go:35:2: `id` is unused (structcheck)
        id string
        ^
pkg/rtc/plugins/buffer.go:58:2: `byteRate` is unused (structcheck)
        byteRate  uint64
        ^
pkg/node/islb/init.go:12:2: `redisKeyTTL` is unused (varcheck)
        redisKeyTTL     = 1500 * time.Millisecond
        ^
ERRO [runner/typecheck] typechecking error: pkg/type/type.go:1:9: expected 'IDENT', found 'type'
pkg/signal/room.go:39:6: `delRoom` is unused (deadcode)
func delRoom(id string) {
     ^
pkg/signal/peer.go:15:6: `getPeer` is unused (deadcode)
func getPeer(rid, id string) *peer.Peer {
     ^
pkg/rtc/router.go:34:6: `rtcpInfo` is unused (deadcode)
type rtcpInfo struct {
     ^
pkg/node/sfu/internal.go:249:6: `trickle` is unused (deadcode)
func trickle(msg map[string]interface{}) (map[string]interface{}, *nprotoo.Error) {
     ^
pkg/discovery/node_test.go:18:2: `nodes` is unused (deadcode)
        nodes []Node
        ^
pkg/node/biz/util.go:10:6: `getMID` is unused (deadcode)
func getMID(uid string) string {
     ^
pkg/node/biz/util.go:14:6: `getKeepAliveID` is unused (deadcode)
func getKeepAliveID(mid string, ssrc uint32) string {
     ^
pkg/node/biz/code.go:3:6: `code` is unused (deadcode)
type code int
     ^
cmd/biz/main.go:29:23: Error return value of `http.ListenAndServe` is not checked (errcheck)
                        http.ListenAndServe(conf.Global.Pprof, nil)
                                           ^
cmd/islb/main.go:24:23: Error return value of `http.ListenAndServe` is not checked (errcheck)
                        http.ListenAndServe(conf.Global.Pprof, nil)
                                           ^
cmd/sfu/main.go:34:23: Error return value of `http.ListenAndServe` is not checked (errcheck)
                        http.ListenAndServe(conf.Global.Pprof, nil)
                                           ^
pkg/db/redis_test.go:49:9: Error return value of `db.HSet` is not checked (errcheck)
        db.HSet(mkey, field, value)
               ^
pkg/db/redis_test.go:57:9: Error return value of `db.HSet` is not checked (errcheck)
        db.HSet(mkey, field, value)
               ^
pkg/db/redis_test.go:64:9: Error return value of `db.HSet` is not checked (errcheck)
        db.HSet(mkey, field, value)
               ^
pkg/discovery/discovery.go:44:12: Error return value of `etcd.keep` is not checked (errcheck)
                etcd.keep(etcdNode, "")
                         ^
pkg/discovery/discovery.go:50:16: Error return value of `etcd.update` is not checked (errcheck)
                                etcd.update(etcdNode, getScore())
                                           ^
pkg/discovery/discovery.go:100:12: Error return value of `etcd.keep` is not checked (errcheck)
                etcd.keep(key, val)
                         ^
pkg/discovery/discovery.go:106:13: Error return value of `etcd.watch` is not checked (errcheck)
                etcd.watch(key, watchFunc, prefix)

@adwpc
Copy link
Collaborator

adwpc commented Mar 30, 2020

@Sean-Der Great work!I have considered CI before!This can make code better and reduce bugs!

@Sean-Der
Copy link
Contributor

@adwpc ok cool I will roll forward with this, just wanted to check first this is something you agree with :)

@cloudwebrtc
Copy link
Contributor

cloudwebrtc commented Mar 30, 2020

@Sean-Der Fully agree, even we can add CI for JS and Flutter to avoid errors.

@at-wat
Copy link
Contributor

at-wat commented Mar 30, 2020

@Sean-Der I suppose this repo don't need WASM test.
We'll be better to have pion/.goassets#21.

@at-wat
Copy link
Contributor

at-wat commented Apr 15, 2020

I'm going to update the CI script to load a config file and make it possible to skip WASM test according to the config.
pion/.goassets#26

@adwpc adwpc closed this May 1, 2020
@tarrencev tarrencev deleted the sync-assets-v0.2.1 branch May 13, 2020 19:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants