feat(gateway-optional): This commit makes gw definition optional for additionalNetworkDevices #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…additionalNetworkDevices There is no need to have a mandatory gateway for secondary network interfaces, this commit edits the validation and go template that is in charge of generating the cloudinit files.
CiraciNicolo
requested review from
65278,
avorima,
lubedacht,
pborn-ionos,
mcbenjemaa and
wikkyk
as code owners
|
thank you, i will check this |
|
Can you share the yaml you used for testing? |
|
I merged the main branch into my feature to check any possible new issues, probably we need to re-approve workflow 😊 |
Hi! Sorry for the delay, you can find below the manifests used - I will provide only the relative manifest and not the whole cluster definition ---
apiVersion: ipam.cluster.x-k8s.io/v1alpha2
kind: GlobalInClusterIPPool
metadata:
name: ippool
spec:
addresses:
- 10.10.10.4-10.10.10.254
prefix: 24
---
kind: ProxmoxMachineTemplate
apiVersion: infrastructure.cluster.x-k8s.io/v1alpha1
metadata:
name: "workers"
spec:
template:
spec:
sourceNode: "source-node"
templateID: 1001
format: "qcow2"
full: true
numSockets: 1
numCores: 4
memoryMiB: 4096
disks:
bootVolume:
disk: virtio0
sizeGb: 100
network:
default:
bridge: vmbr0
additionalDevices:
- bridge: vmbr0
name: net1
ipv4PoolRef:
apiGroup: ipam.cluster.x-k8s.io
kind: GlobalInClusterIPPool
name: ippool |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
There is no need to have a mandatory gateway for secondary network interfaces, this commit edits the validation and go template that is in charge of generating the cloudinit files.
Testing performed:
Bootstrapped two machines:
Both machine got provisioned