Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Go to v1.21 #135

Merged
merged 4 commits into from
Mar 13, 2024
Merged

Upgrade Go to v1.21 #135

merged 4 commits into from
Mar 13, 2024

Conversation

mcbenjemaa
Copy link
Member

No description provided.

@mcbenjemaa mcbenjemaa self-assigned this Mar 12, 2024
@mcbenjemaa mcbenjemaa changed the title Update Go to v1.21 Upgrade Go to v1.21 Mar 12, 2024
@avorima
Copy link
Collaborator

avorima commented Mar 12, 2024

Tests are failing because you mix context.TODO() and context.Background() in your mock assertions

@mcbenjemaa
Copy link
Member Author

Yeah, i know.

In 1.20 It ignores that.

@wikkyk
Copy link
Collaborator

wikkyk commented Mar 13, 2024

ref #116

@wikkyk wikkyk added this to the v0.4.0 milestone Mar 13, 2024
@mcbenjemaa
Copy link
Member Author

Please run e2e tests

@mcbenjemaa
Copy link
Member Author

Tested ✅

@mcbenjemaa mcbenjemaa enabled auto-merge (squash) March 13, 2024 14:36
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mcbenjemaa mcbenjemaa merged commit 4784484 into main Mar 13, 2024
7 of 8 checks passed
@mcbenjemaa mcbenjemaa deleted the go-1.21 branch March 13, 2024 15:01
@mcbenjemaa mcbenjemaa mentioned this pull request Mar 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avorima avorima avorima approved these changes

@65278 65278 Awaiting requested review from 65278 65278 is a code owner

@lubedacht lubedacht Awaiting requested review from lubedacht lubedacht is a code owner

@pborn-ionos pborn-ionos Awaiting requested review from pborn-ionos pborn-ionos is a code owner

@wikkyk wikkyk Awaiting requested review from wikkyk wikkyk is a code owner

Assignees

@mcbenjemaa mcbenjemaa

Labels
None yet
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mcbenjemaa @avorima @wikkyk