cluster-template-external-creds: Fix name of the Secret #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the `cluster-template-external-creds` template with `clusterctl`, the following error is obtained: ``` Error: failed to parse yaml: failed to unmarshal the 3rd yaml document: "apiVersion: v1\nstringData:\n secret: REDACTED\n token: REDACTED\n url: https://REDACTED:8006\nkind: Secret\nmetadata:\n name: \"kind-monk2\"-proxmox-credentials\n labels:\n platform.ionos.com/secret-type: \"proxmox-credentials\"\n": error converting YAML to JSON: yaml: line 7: did not find expected key ``` Fixing the `name` key as outlined by this commit resolves the issue.
tbabej
requested review from
65278,
avorima,
lubedacht,
pborn-ionos,
mcbenjemaa and
wikkyk
as code owners
|
|
Good catch, thank you! |
wikkyk
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
cluster-template-external-credstemplate withclusterctl, the following error is obtained:Fixing the
namekey as outlined by this commit resolves the issue.