Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the VM name lazy intialize #61

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Fix the VM name lazy intialize #61

merged 3 commits into from
Jan 17, 2024

Conversation

mcbenjemaa
Copy link
Member

@mcbenjemaa mcbenjemaa commented Jan 17, 2024 •
edited
Loading

Closes #56

@mcbenjemaa mcbenjemaa self-assigned this Jan 17, 2024
wikkyk
wikkyk previously approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@wikkyk wikkyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor spelling nitpicks.
Please don't forget to squash before merging.

internal/service/vmservice/find.go Outdated Show resolved Hide resolved
internal/service/vmservice/find.go Outdated Show resolved Hide resolved
@mcbenjemaa mcbenjemaa merged commit 01911ec into main Jan 17, 2024
9 checks passed
@mcbenjemaa mcbenjemaa deleted the fix-wrong-name branch January 17, 2024 14:47
@mcbenjemaa mcbenjemaa mentioned this pull request Jan 18, 2024
Merged
wikkyk pushed a commit that referenced this pull request Jan 22, 2024
@avorima
Display selected node in printcolumn (#61)
511eaeb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wikkyk wikkyk wikkyk approved these changes

Assignees

@mcbenjemaa mcbenjemaa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: machines fails to reconcile due to wrong name
2 participants
@mcbenjemaa @wikkyk