fly-by: Allow specifying packages to test #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avorima
requested review from
65278,
lubedacht,
pborn-ionos,
mcbenjemaa and
wikkyk
as code owners
mcbenjemaa
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
I wanted to test the webhook package, but found there was no easy way of running the tests because it needs envtest binaries.
Description of changes:
Add Makefile variable
WHATthat controls what tests should be run. Defaults to./....WHATmust be a valid go package specification.Also updated the envtest k8s version to 1.28.0, because the go.mod uses 1.28.X.
Testing performed:
I ran
make testwith different values ofWHATlocally.