Refactor/composite requests #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ionoscloud.go
Outdated
| Name: &additionalNicName, | ||
| Lan: &additionalLanId_int32, | ||
| Ips: nil, | ||
| Dhcp: &dhcp_true, |
There was a problem hiding this comment.
just a nitpick but we have SDK util funcs that help us get rid of these variables:
I mean we can do Dhcp: sdkgo.ToPtr(true) instead of Dhcp: &dhcp_true
ionoscloud.go
Outdated
| log.Debugf("Nic ID: %v", d.NicId) | ||
| volumes, ok := server.Entities.GetVolumesOk() | ||
| if !ok { | ||
| return fmt.Errorf("error getting server: d.ServerId is empty") |
There was a problem hiding this comment.
I think this error message is wrong, wouldn't this print error getting server: d.ServerId is empty when in fact there are no volumes on that server?
avirtopeanu-ionos
previously approved these changes
Feb 29, 2024
avirtopeanu-ionos
previously approved these changes
Mar 1, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this fix or implement?
Checklist
feat:/fix:/doc:/test:/refactor:)