Refactor/catch driver errors #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ionos_create_machine.go
Outdated
| } | ||
| err = d.CreateLanIfNeeded() | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
(just a nitpick)
it would be easier to rather append the error here rather than in the called function i.e.
Suggested change
| return err | |
| return fmt.Errorf("error creating LAN: %w", err) |
ionos_create_machine.go
Outdated
| } | ||
|
|
||
| func (d *Driver) CreateLanIfNeeded() (err error) { | ||
| if d.LanId == "" { |
There was a problem hiding this comment.
(just a nitpick)
It would be easier to read if this is an early return
Suggested change
| if d.LanId == "" { | |
| if d.LanId != "" { | |
| return nil | |
| } | |
| /// rest of the func not nested |
ionos_create_machine.go
Outdated
| } | ||
|
|
||
| func (d *Driver) CreateIonosMachine() (err error) { | ||
| log.Infof("Creating SSH key123...") |
There was a problem hiding this comment.
Suggested change
| log.Infof("Creating SSH key123...") | |
| log.Infof("Creating SSH key...") |
avirtopeanu-ionos
previously approved these changes
May 8, 2024
rmocanu-ionos
dismissed
avirtopeanu-ionos’s stale review
The base branch was changed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this fix or implement?
Checklist
feat:/fix:/doc:/test:/refactor:)