feat: interactive shell command #268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avirtopeanu-ionos
force-pushed
the
feat/interactive-shell
branch
from
afee029
to
09b3144
Compare
avirtopeanu-ionos
force-pushed
the
feat/interactive-shell
branch
from
09b3144
to
06a64e0
Compare
|
Kudos, SonarCloud Quality Gate passed! |
cristiGuranIonos
approved these changes
Mar 29, 2023
gabriel-savu
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add interactive shell command:
ionosctl shellNOTE: This PR does NOT add flag value completions. Those are blocked by the following issue: stromland/cobra-prompt#10 (note: we can simply use a fork). The mentioned github issue is blocked by this cobra issue: spf13/cobra#1942 which would be fixed by this cobra PR spf13/cobra#1943 (note: using a fork for Cobra could cause some extra maintenance work. Using a fork for cobra-prompt is fine, in fact I would prefer doing so)