Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow MariaDB cluster creation in multiple locations #555

Merged
merged 5 commits into from
May 31, 2024
Merged

feat: Allow MariaDB cluster creation in multiple locations #555

merged 5 commits into from
May 31, 2024

Conversation

adeatcu-ionos
Copy link
Contributor

What does this fix or implement?

Checklist

  • PR name added as appropriate (e.g. feat:/fix:/doc:/test:/refactor:)
  • Tests added or updated
  • Documentation updated
  • Changelog updated and version incremented (label: upcoming release)
  • Github Issue linked if any
  • Jira task updated

@adeatcu-ionos adeatcu-ionos force-pushed the allow-mariadb-cluster-creation-multiple-locations branch 2 times, most recently from 86c3a1f to 3f4563e Compare May 20, 2024 07:44
@adeatcu-ionos
Copy link
Contributor Author

@cbeti-ionos I made the location attribute optional, please take another look when you get the chance. Thank you!

@adeatcu-ionos adeatcu-ionos force-pushed the allow-mariadb-cluster-creation-multiple-locations branch 2 times, most recently from 9a3f72a to f5a97d5 Compare May 27, 2024 11:35
@adeatcu-ionos adeatcu-ionos force-pushed the allow-mariadb-cluster-creation-multiple-locations branch 13 times, most recently from 4ce63cf to a5f1e38 Compare May 29, 2024 11:32
@adeatcu-ionos adeatcu-ionos force-pushed the allow-mariadb-cluster-creation-multiple-locations branch from a5f1e38 to e2c9fa2 Compare May 29, 2024 11:38
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@cristiGuranIonos cristiGuranIonos merged commit fe837a1 into master May 31, 2024
6 checks passed
@cristiGuranIonos cristiGuranIonos deleted the allow-mariadb-cluster-creation-multiple-locations branch May 31, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbeti-ionos cbeti-ionos cbeti-ionos approved these changes

@cristiGuranIonos cristiGuranIonos Awaiting requested review from cristiGuranIonos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adeatcu-ionos @cbeti-ionos @cristiGuranIonos