Skip to content

Commit

Permalink
Windows local build fixes
Browse files Browse the repository at this point in the history
* The directory dcos_build_venv must be deleted only if it already exists.
* Fix pip upgrade. The following issue explains the situation and the
  proposed workaround proposed: pypa/pip#3804
  • Loading branch information
ionutbalutoiu committed May 22, 2018
1 parent 2c41bb1 commit 26ff9f3
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
5 changes: 4 additions & 1 deletion build_local_windows.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,10 @@ if ( ! $tmpdir ) {
}

# Cleanup from previous build
rm -recurse "$tmpdir/dcos_build_venv"
$venvDir = "$tmpdir/dcos_build_venv"
if(Test-Path $venvDir) {
rm -recurse -force "$tmpdir/dcos_build_venv"
}

# Force Python stdout/err to be unbuffered.
$env:PYTHONUNBUFFERED="notempty"
Expand Down
2 changes: 1 addition & 1 deletion prep_local_windows.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ if (!$env:VIRTUAL_ENV) {
}

# Install the latest version of pip
pip install -U pip
python -m pip install -U pip

# Install the packages in editable mode to the virtual environment.
pip install -e $PWD

0 comments on commit 26ff9f3

Please sign in to comment.