For mozilla-mobile#5720 - Dismiss context menu at lateral tapping

Remove the background with inset and use windowMinWidthMajor, windowMinWidthMinor
ionutbedregeanu · Nov 3, 2021 · 232bf3a · 232bf3a
1 parent 2508786
commit 232bf3a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 11 deletions.
diff --git a/app/src/main/res/drawable/dialog_background_with_insets.xml b/app/src/main/res/drawable/dialog_background_with_insets.xml
diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml
@@ -36,6 +36,8 @@
     <dimen name="adaptive_icon_drawable_dimen">108dp</dimen> <!-- Specified in AdaptiveIconDrawable docs. -->
 
     <dimen name="dialogHorizontalPadding">24dp</dimen>
+    <dimen name="dialog_min_width_major">65%</dimen>
+    <dimen name="dialog_min_width_minor">75%</dimen>
 
     <dimen name="preference_root_layout_padding">16dp</dimen>
     <dimen name="preference_icon_drawable_size">24dp</dimen>

diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml
@@ -66,7 +66,10 @@
         <item name="android:windowTitleStyle">@style/DialogTitleStyle</item>
         <item name="android:textColorPrimary">@color/primaryText</item>
         <item name="dialogPreferredPadding">24dp</item>
-        <item name="android:windowBackground">@drawable/dialog_background_with_insets</item>
+        <item name="android:windowBackground">@drawable/dialog_background</item>
+        <item name="android:windowMinWidthMajor">@dimen/dialog_min_width_major</item>
+        <item name="android:windowMinWidthMinor">@dimen/dialog_min_width_minor</item>
+
         <!-- This is the default color for activated controls(buttons) -->
         <item name="android:colorAccent">@color/accentBright</item>
         <item name="textColorAlertDialogListItem">@color/primaryText</item>