This repository has been archived by the owner on Jan 27, 2021. It is now read-only.
Improve tree shaking #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `sideEffects: false` to package.json Use `annotate-pure-calls` babel plugin
|
I've just seen the typo in the commit message. Feel free to fix it when merging. |
|
I think minor is fair. |
jpeyper
approved these changes
Apr 18, 2018
mpeyper
pushed a commit
to mpeyper/redux-dynostore
that referenced
this pull request
Oct 23, 2018
Refactor `detachReducers` implementation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
sideEffects: falseto package.jsonUse
annotate-pure-callsbabel pluginThese changes bring our tree-shaking setup in line with what has been done up to date in
redux-subspace.See ioof-holdings/redux-subspace#78 and ioof-holdings/redux-subspace#85 for more details.
I've marked this as a minor version as it not really a bug fix, but it could probably go out as a patch as it's not really a new feature either.