Skip to content
This repository has been archived by the owner on Jan 27, 2021. It is now read-only.

Added compatability package for redux-observable #37

Merged
merged 13 commits into from Aug 23, 2017

Conversation

mpeyper
Copy link
Contributor

@mpeyper mpeyper commented Aug 21, 2017

redux-observable had the same issue as redux-saga where the epics run external to redux itself, so a subspaced wrapper needed to be wrapped around any epics that should run in a subspace.

@jcheroske's enhanceEpic in #32 served as the initial inspiration for the solution, which was able to be simplified with the v2 improvements made in #34.

@mpeyper
Copy link
Contributor Author

mpeyper commented Aug 21, 2017

I also (finally) figured out how to get the redux-subspace-saga typescript definition tests working.

@@ -0,0 +1,5 @@
# redux-saga
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes :(

Copy link
Collaborator

@jpeyper jpeyper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well documented and tested.

@mpeyper mpeyper mentioned this pull request Aug 21, 2017
@jpeyper jpeyper merged commit 2e6c269 into ioof-holdings:master Aug 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants