Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Node 8 #48

Closed
ewindisch opened this issue Jun 6, 2018 · 4 comments
Closed

Support Node 8 #48

ewindisch opened this issue Jun 6, 2018 · 4 comments
Assignees

Comments

@ewindisch
Copy link
Contributor

This is now built in although considered experimental:
https://nodejs.org/api/inspector.html

@ewindisch ewindisch self-assigned this Jun 6, 2018
@ewindisch
Copy link
Contributor Author

Briefly discussed with @coreylight for fidelity and it seems with this we'd create a v1 branch of the current code to support Node v6.10. Then, we'd maintain master off the new node stdlib inspector module.

@ewindisch
Copy link
Contributor Author

Work in progress branch: https://github.com/ewindisch/iopipe-plugin-profiler/tree/node8

I expect this should be ready for become a PR within a couple days!

@ewindisch
Copy link
Contributor Author

ewindisch commented Jun 8, 2018

Addressed by #49

@ewindisch
Copy link
Contributor Author

Branch with continued work to attempt getting heap profiling working. This has a bunch of wolf-fencing and other things built-in (as of writing this), and is non-working... so I didn't want to commit it to the otherwise working 'node8' branch: https://github.com/ewindisch/iopipe-plugin-profiler/tree/node8heap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants