Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Node 8.10 #7

Open
pselle opened this issue Apr 18, 2018 · 1 comment
Open

Support Node 8.10 #7

pselle opened this issue Apr 18, 2018 · 1 comment

Comments

@pselle
Copy link
Contributor

pselle commented Apr 18, 2018

The install script targets 6.10:

https://github.com/iopipe/v8-profiler-lambda/blob/master/package.json#L34

Given 8.10 support on Lambda, this should be more nuanced to support 6 & 8 engine profilers

cc @ewindisch am I on the right track here?
@pselle
Copy link
Contributor Author

pselle commented May 29, 2018

In investigating, there's not a pre-built for 8.10, and it doesn't appear that v8profiler is moving to make this available -- perhaps we should host our own pre-built?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pselle