Skip to content

Commit

Permalink
SDL 2 scroll/caps/num lock keys send KEYUP event when key is released
Browse files Browse the repository at this point in the history
  • Loading branch information
zturtleman committed Aug 29, 2014
1 parent 18e0812 commit 1d95ef2
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 25 deletions.
3 changes: 0 additions & 3 deletions README.md
Expand Up @@ -438,9 +438,6 @@ Note that this cvar MUST be set as a command line parameter.
ioquake3 clients have different keyboard behaviour compared to the original
Quake3 clients.

* "Caps Lock" and "Num Lock" can not be used as normal binds since they
do not send a KEYUP event until the key is pressed again.

* SDL > 1.2.9 does not support disabling dead key recognition. In order to
send dead key characters (e.g. ~, ', `, and ^), you must key a Space (or
sometimes the same character again) after the character to send it on
Expand Down
8 changes: 2 additions & 6 deletions code/client/cl_keys.c
Expand Up @@ -1207,7 +1207,7 @@ void CL_KeyDownEvent( int key, unsigned time )
{
keys[key].down = qtrue;
keys[key].repeats++;
if( keys[key].repeats == 1 && key != K_SCROLLOCK && key != K_KP_NUMLOCK && key != K_CAPSLOCK )
if( keys[key].repeats == 1 )
anykeydown++;

if( keys[K_ALT].down && key == K_ENTER )
Expand Down Expand Up @@ -1299,8 +1299,7 @@ void CL_KeyUpEvent( int key, unsigned time )
{
keys[key].repeats = 0;
keys[key].down = qfalse;
if (key != K_SCROLLOCK && key != K_KP_NUMLOCK && key != K_CAPSLOCK)
anykeydown--;
anykeydown--;

if (anykeydown < 0) {
anykeydown = 0;
Expand Down Expand Up @@ -1385,9 +1384,6 @@ void Key_ClearStates (void)
anykeydown = 0;

for ( i=0 ; i < MAX_KEYS ; i++ ) {
if (i == K_SCROLLOCK || i == K_KP_NUMLOCK || i == K_CAPSLOCK)
continue;

if ( keys[i].down ) {
CL_KeyEvent( i, qfalse, 0 );

Expand Down
16 changes: 0 additions & 16 deletions code/sdl/sdl_input.c
Expand Up @@ -908,20 +908,6 @@ void IN_Frame( void )
}
}

/*
===============
IN_InitKeyLockStates
===============
*/
void IN_InitKeyLockStates( void )
{
const unsigned char *keystate = SDL_GetKeyboardState(NULL);

keys[K_SCROLLOCK].down = keystate[SDL_SCANCODE_SCROLLLOCK];
keys[K_KP_NUMLOCK].down = keystate[SDL_SCANCODE_NUMLOCKCLEAR];
keys[K_CAPSLOCK].down = keystate[SDL_SCANCODE_CAPSLOCK];
}

/*
===============
IN_Init
Expand Down Expand Up @@ -959,8 +945,6 @@ void IN_Init( void *windowData )
Cvar_SetValue( "com_unfocused", !( appState & SDL_WINDOW_INPUT_FOCUS ) );
Cvar_SetValue( "com_minimized", appState & SDL_WINDOW_MINIMIZED );

IN_InitKeyLockStates( );

IN_InitJoystick( );
Com_DPrintf( "------------------------------------\n" );
}
Expand Down

0 comments on commit 1d95ef2

Please sign in to comment.