Fix undefined behaviour due to shifting signed in snd_mem.c

ioquake · Apr 9, 2018 · a494ede · a494ede
1 parent 4ea0eeb
commit a494ede
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/code/client/snd_mem.c b/code/client/snd_mem.c
@@ -141,7 +141,7 @@ static int ResampleSfx( sfx_t *sfx, int channels, int inrate, int inwidth, int s
 			if( inwidth == 2 ) {
 				sample = ( ((short *)data)[srcsample+j] );
 			} else {
-				sample = (int)( (unsigned char)(data[srcsample+j]) - 128) << 8;
+				sample = (unsigned int)( (unsigned char)(data[srcsample+j]) - 128) << 8;
 			}
 			part = (i*channels+j)&(SND_CHUNK_SIZE-1);
 			if (part == 0) {