Fix potential buffer overflow caused by long tcMod args

Found by Coverity.
ioquake · May 25, 2014 · eeeaf3f · eeeaf3f
1 parent 9c99cf2
commit eeeaf3f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/code/renderergl1/tr_shader.c b/code/renderergl1/tr_shader.c
@@ -1010,8 +1010,8 @@ static qboolean ParseStage( shaderStage_t *stage, char **text )
 				token = COM_ParseExt( text, qfalse );
 				if ( token[0] == 0 )
 					break;
-				strcat( buffer, token );
-				strcat( buffer, " " );
+				Q_strcat( buffer, sizeof (buffer), token );
+				Q_strcat( buffer, sizeof (buffer), " " );
 			}
 
 			ParseTexMod( buffer, stage );

diff --git a/code/renderergl2/tr_shader.c b/code/renderergl2/tr_shader.c
@@ -1265,8 +1265,8 @@ static qboolean ParseStage( shaderStage_t *stage, char **text )
 				token = COM_ParseExt( text, qfalse );
 				if ( token[0] == 0 )
 					break;
-				strcat( buffer, token );
-				strcat( buffer, " " );
+				Q_strcat( buffer, sizeof (buffer), token );
+				Q_strcat( buffer, sizeof (buffer), " " );
 			}
 
 			ParseTexMod( buffer, stage );