Added #get_node, #node_exists? methods on Graph and relevant tests. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lso changed identation to match Ruby standard.
ioquatix
reviewed
Jul 19, 2018
spec/graphviz/graph_spec.rb
Outdated
| @@ -20,13 +20,13 @@ | |||
|
|
|||
| require 'graphviz' | |||
|
|
|||
| SAMPLE_GRAPH_DOT = <<~EOF | |||
| digraph "G" { | |||
| SAMPLE_GRAPH_DOT = <<-EOF | |||
There was a problem hiding this comment.
This was necessary for the gem to run on versions earlier than 2.3. The squiggly <<~ HEREDOC syntax was introduced in Ruby 2.3 and previous versions will raise error when <<~ is used.
There was a problem hiding this comment.
Fair enough. I'm not actually too concerned about that since Ruby < 2.3 is EOL.
|
Please don't reformat the entire code base. Especially don't do it with functional code changes :) |
|
Okay, this looks good. I will review in more detail after merging. |
|
Okay I released it as v1.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added method to return Node based on node name. Added method to check if Node exists in the graph. Also changed indentation to match Ruby standard. Fixed minor bug in demo.rb.