Fix bug in delete_until logic in replace_section.

ioquatix · Jun 17, 2023 · 03d0723 · 03d0723
1 parent 878ccd4
commit 03d0723
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/markly/node.rb b/lib/markly/node.rb
@@ -100,7 +100,7 @@ def delete_until
 		def replace_section(new_node, replace_header: true, remove_subsections: true)
 			# Delete until the next heading:
 			self.next&.delete_until do |node|
-				node.type == :heading && (!remove_subsections || node.header_level <= self.header_level)
+				node.type == :header && (!remove_subsections || node.header_level <= self.header_level)
 			end
 
 			self.append_after(new_node) if new_node

diff --git a/test/markly/node.rb b/test/markly/node.rb
@@ -216,7 +216,7 @@
 
 		it "can replace a section and subsections" do
 			document.find_header("Heading").replace_section(new_document.first_child, remove_subsections: false)
-			expect(document.to_html).to be == "<h3>New Heading</h3>\n"
+			expect(document.to_html).to be == "<h3>New Heading</h3>\n<h2>Subheading</h2>\n"
 		end
 	end
 end