Add support for Safari on iOS #99

iorate · 2021-06-13T15:32:54Z

Update (Sep 25, 2022)

uBlacklist is now available on iOS/iPadOS 15 thanks to @HoneyLuka !
https://apps.apple.com/us/app/ublacklist-for-safari/id1547912640

TODO:

image search
news search
video search

Apple has announced that iOS 15 will support Safari Web Extensions.
https://developer.apple.com/videos/play/wwdc2021/10104/

Thanks to @HoneyLuka, uBlacklist is already available as a Safari Web Extension on macOS.
I'd like to add support for Safari on iOS because I'm an iPhone and iPad user.

HoneyLuka · 2021-06-13T15:36:18Z

Thanks for your contribution. Can't wait to use it. :)

HoneyLuka · 2021-06-13T15:40:31Z

And if you need to get control of the macOS app for some reason, please let me know and I will transfer it to you any time. 🙏

iorate · 2021-06-14T14:05:52Z

@HoneyLuka
Thanks, but for now I don't need control of the macOS app.

I will contact you here when I implement support for Safari on iOS 15.

add initial support for the modern version of SERP for Chrome and Safari re: #99

re: #99

iorate · 2021-09-15T16:13:26Z

iOS/iPadOS 15 will be released on Sep 20!
https://www.apple.com/ios/ios-15/

I pushed a commit (9299d45) which added initial support for Safari 15 on iOS.
Although it supports only simple results in the "All" search, it seems to work well on iOS simulator:

I will add support for more types of search results later.

@HoneyLuka Could you please publish "uBlacklist for Safari" for iOS/iPadOS after iOS/iPadOS 15 are released and you think this extension supports them sufficiently?

HoneyLuka · 2021-09-16T06:03:36Z

@iorate Thanks for your work🎉, I think it's fine for a first release on iOS. I am now starting to work on the iOS version release preparation

iorate · 2021-09-16T13:59:44Z

@HoneyLuka Thank you. I'm looking forward to it.

iorate · 2021-09-18T12:45:19Z

The build system was upgraded for faster builds using esbuild-loader.
To generate a production build for Safari:

# Install dependencies
- yarn install --frozen-lockfile
+ yarn install --immutable

# Build
- yarn build:safari:production
+ yarn build safari production

cc: @HoneyLuka

HoneyLuka · 2021-09-18T13:08:28Z

@iorate Thank you for the tips. I will use it tomorrow.

iOS version almost done. When I finished, I will tell you here.

HoneyLuka · 2021-09-19T06:40:27Z

@iorate When I debug on iPad, I found an UI issue.

An alternative to browser.identity.launchWebAuthFlow is implemented. The redirect URL is 'https://iorate.github.io/ublacklist/callback'. Because Safari on iOS 15 seems not to support browser.tabs.onUpdate (and browser.tabs.onRemoved) currently, we cannot detect authentication completion and read the authorization code automatically. Users need to copy and paste the authorization code manually. re #99

re #99

iorate · 2021-09-19T11:09:40Z

@HoneyLuka Thank you for reporting an issue. Does the latest commit (017bf78) fix the problem?

HoneyLuka · 2021-09-19T11:21:53Z

@iorate I merged your master branch, It's OK👍

iorate · 2021-09-19T11:33:54Z

@HoneyLuka I'm glad to hear that.

I would appreciate if you could also check the sync feature that I added a bit before (3fb1257). Because Safari on iOS lacks some APIs, users need to copy authorization codes from iorate.github.io manually.

HoneyLuka · 2021-09-19T11:49:15Z

@iorate ok, I will try it later, if any questions I will report to you.

HoneyLuka · 2021-09-19T12:44:46Z

@iorate I create a test dropbox app, set it's callback url to iorate.github.io.

Most functions are working. Only a little problem:

After sync finished, Appearance, Subscription module do not refresh automatically. Rules textarea show a tips 'updated Reload'. Maybe reload the whole options page automatically after sync?

re #99

iorate · 2021-09-19T14:12:53Z

@HoneyLuka Thank you for your feedback.

Maybe reload the whole options page automatically after sync?

I don't like automatic reload so much, so added a manual-reload button.
(The screenshot below is taken in Firefox on Windows)

HoneyLuka · 2021-09-20T10:43:17Z

@iorate I have completed the development of the iOS version, and ready for app store review, the first version is reviewing for external test(TestFlight External Test).

If you want to build yourself, you can get code from my branch.

Should I submit the current release to app store or waiting for your next tag and rebuild a new release ?

iorate · 2021-09-20T12:39:40Z

@HoneyLuka Great!

Would you please bulid the current master (just marked as v6.4.0) and submit it as v6.4.0?

(As a side note, v6.4.0 will not be released for Chrome & Firefox. v6.3.6 is still under review by Chrome Web Store...)

HoneyLuka · 2021-09-20T12:44:12Z

@iorate ok, I will rebuild as 6.4.0 later.

iorate · 2021-09-20T13:36:54Z

I added v6.4.1 (and perhaps will add more) because v6.3.6 is rejected by Chrome Web Store.
This does not affect the Safari version.

cyshallchan · 2021-09-20T17:48:33Z

@HoneyLuka 🤣已经在等了。

HoneyLuka · 2021-09-21T01:34:07Z

@HoneyLuka 🤣已经在等了。

Welcome to be the first user of iOS version🎉

HoneyLuka · 2021-09-21T02:18:11Z

@iorate @cyshallchan iOS version is online🎉 Link

cyshallchan · 2021-09-21T08:38:14Z

@iorate @HoneyLuka Already used, thank you two very much.

iorate · 2021-09-21T12:41:04Z

@HoneyLuka
I installed "uBlacklist for Safari" to iOS 15 (on iPhone 11 Pro) and iPadOS 15 (on iPad Pro 12.9-inch)
and confirmed it worked well.
Thank you for your excellent work!

iorate · 2021-09-21T12:43:55Z

We should add support for:

image search
news search
video search

iorate · 2021-09-22T12:42:22Z

Synchronization and subscription updates may not occur regularly. In such cases, the alarms are certainly set, but Safari does not fire them.

(18 hours behind!)

I'm not sure what the reproduction conditions are.

HoneyLuka · 2021-09-22T14:41:38Z

@iorate
Does this bug appear when the Safari app is in the background?
Usually in native app of iOS, when the app switches to the background, OS give app a short time to execute code. After that the app will become background/sleep state, can't execute code, and Timer also can't fire(suspend).
When the app active again, the timer will be resume.

I think this bug is very similar to native app. Because Safari is also a native app, when it is in the background, the activity of the extension is suspended due to battery life considerations

iorate · 2021-09-23T05:34:54Z

@HoneyLuka
I think it is reasonable that alarms are not fired when Safari is in background, but alarms should be resumed after Safari is back to foreground as you say.

However, I have met some different situations:

Sync (every 15 minutes) and subscription (every 2 hours) did not occur after moving Safari from background for several hours to foreground
Sync (every 15 minutes) and subscription (every 2 hours) occurred immediately after moving Safari from background for several hours to foreground
Sync (every 15 minutes) occurred but subscription (every 2 hours) did not occur after moving Safari from background for several hours to foreground
Sync (every 5 minites) and subscription (every 5 minutes) did not occur even when I kept Safari in foreground during the interval

I don't understand the behavior of Safari...

HoneyLuka · 2021-09-23T06:45:52Z

@iorate
This may be a bug in Safari, which is not surprising.

If this is indeed a bug, I'm thinking of a solution.
I'm not good at web development. I'm not sure if there is a way to let the extension know about Safari state changes. After a short search, I found an event windows.onFocusChanged. Maybe when Safari become active, this event will be callback. The document said this works after Safari 14 (maybe it's macOS Safari 14).
If it is indeed, in unfocus event remove all alarms, and in focus event recreate them (More complex logic can also be added, for example fire an update immediately or based on last fire time).

Summary Steps:

Check if windows.onFocusChanged is Working properly.
Check recreated alarm is Working properly. (If this bug is more critical, the recreated alarm maybe also does not work properly)
If both is ok, write code on event callback.

iorate · 2021-09-23T09:44:39Z

@HoneyLuka
Sounds good.
windows.onFocusChanged seems to work in iOS Simulator.

re #99

iorate · 2021-09-24T03:22:52Z

I've been trying the windows.onFocusChanged hack for half a day on my iPhone and iPad.
So far, it seems to be working.

HoneyLuka · 2021-09-24T03:48:47Z

@iorate Glad it works. Thank your for your hard work.

iorate · 2021-09-24T11:19:40Z

I believe it works.
@HoneyLuka Would you please publish v6.6.0 when it's convenient for you?

HoneyLuka · 2021-09-24T11:22:07Z

@iorate Thank you🎉, I will submit it to app store right now.

HoneyLuka · 2021-09-25T04:50:34Z

iOS 6.6.0 is online now.

iorate · 2021-09-25T08:50:55Z

@HoneyLuka
It works well on my actual devices. Thanks!

love4taylor · 2021-09-30T09:38:30Z

Is it possible to use CloudKit to synchronize data?

HoneyLuka · 2021-09-30T10:26:14Z

Is it possible to use CloudKit to synchronize data?

I haven't look this part yet. Usually Apple's services are only available on Apple devices.
Even it is possible, I don't think it's necessary to do this right now.
There is a lot of work to do for this feature.

re #99

iorate · 2021-10-03T11:59:30Z

Image, news and video search support is available in v6.7.0. cc: @HoneyLuka

iorate · 2021-10-03T12:01:35Z

@HoneyLuka The screenshots and captions seem to mismatch in the iPad app.

HoneyLuka · 2021-10-03T12:33:39Z

@HoneyLuka The screenshots and captions seem to mismatch in the iPad app.

It seems a bug, I will fix it later and release 6.7.0

HoneyLuka · 2021-10-04T11:45:46Z

iOS 6.7.0 is online🎉

iorate · 2021-10-04T17:43:34Z

@HoneyLuka thanks!

iorate · 2021-10-04T17:48:19Z

I'm closing this issue because I think basic support for iOS is already done.
For further problems on iOS, please create individual issues for each problem.

iorate pinned this issue Jun 13, 2021

iorate mentioned this issue Sep 14, 2021

Stopped working on mobile version of Google Search #118

Closed

iorate added a commit that referenced this issue Sep 15, 2021

chore(google): prepare for iOS 15

9299d45

add initial support for the modern version of SERP for Chrome and Safari re: #99

iorate added a commit that referenced this issue Sep 15, 2021

chore: fix UI for iOS 15

18c3915

re: #99

iorate added a commit that referenced this issue Sep 19, 2021

chore: work around an UI issue on iPad

017bf78

re #99

iorate added a commit that referenced this issue Sep 19, 2021

feat(options): show a reload button after downloading settings

bbc2d22

re #99

iorate added a commit that referenced this issue Sep 23, 2021

fix(ios): work around the sync problem

11c7166

re #99

iorate added a commit that referenced this issue Sep 23, 2021

fix(ios): work around the sync problem

9218645

re #99

iorate added a commit that referenced this issue Oct 3, 2021

feat(ios): add support for image, news and video search

dad88b9

re #99

iorate closed this as completed Oct 4, 2021

iorate unpinned this issue Oct 4, 2021

Add support for Safari on iOS #99

Add support for Safari on iOS #99

Comments

iorate commented Jun 13, 2021 • edited Loading

HoneyLuka commented Jun 13, 2021

HoneyLuka commented Jun 13, 2021

iorate commented Jun 14, 2021

iorate commented Sep 15, 2021

HoneyLuka commented Sep 16, 2021

iorate commented Sep 16, 2021

iorate commented Sep 18, 2021

HoneyLuka commented Sep 18, 2021

HoneyLuka commented Sep 19, 2021

iorate commented Sep 19, 2021

HoneyLuka commented Sep 19, 2021

iorate commented Sep 19, 2021

HoneyLuka commented Sep 19, 2021

HoneyLuka commented Sep 19, 2021

iorate commented Sep 19, 2021

HoneyLuka commented Sep 20, 2021

iorate commented Sep 20, 2021

HoneyLuka commented Sep 20, 2021

iorate commented Sep 20, 2021

cyshallchan commented Sep 20, 2021

HoneyLuka commented Sep 21, 2021

HoneyLuka commented Sep 21, 2021 • edited Loading

cyshallchan commented Sep 21, 2021

iorate commented Sep 21, 2021

iorate commented Sep 21, 2021

iorate commented Sep 22, 2021

HoneyLuka commented Sep 22, 2021

iorate commented Sep 23, 2021 • edited Loading

HoneyLuka commented Sep 23, 2021 • edited Loading

iorate commented Sep 23, 2021

iorate commented Sep 24, 2021 • edited Loading

HoneyLuka commented Sep 24, 2021

iorate commented Sep 24, 2021

HoneyLuka commented Sep 24, 2021

HoneyLuka commented Sep 25, 2021

iorate commented Sep 25, 2021

love4taylor commented Sep 30, 2021

HoneyLuka commented Sep 30, 2021

iorate commented Oct 3, 2021

iorate commented Oct 3, 2021

HoneyLuka commented Oct 3, 2021

HoneyLuka commented Oct 4, 2021

iorate commented Oct 4, 2021

iorate commented Oct 4, 2021

iorate commented Jun 13, 2021 •

edited

Loading

HoneyLuka commented Sep 21, 2021 •

edited

Loading

iorate commented Sep 23, 2021 •

edited

Loading

HoneyLuka commented Sep 23, 2021 •

edited

Loading

iorate commented Sep 24, 2021 •

edited

Loading