feat(android): unlock sync feature (#382)

iorate · Nov 28, 2023 · 2d0096d · 2d0096d
1 parent 3d5a4a8
commit 2d0096d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 10 deletions.
diff --git a/src/scripts/clouds/helpers.ts b/src/scripts/clouds/helpers.ts
@@ -30,10 +30,19 @@ async function launchAltFlow(params: { url: string }): Promise<string> {
   if (openerTabId == null) {
     throw new Error('failed to get the current tab');
   }
+  // #if !FIREFOX
   const { id: authorizationTabId } = await browser.tabs.create({
     openerTabId,
     url: params.url,
   });
+  /* #else
+  const { id: authorizationTabId } = await browser.tabs.create(
+    (await browser.runtime.getPlatformInfo()).os === 'android'
+      ? { url: params.url }
+      : { openerTabId, url: params.url },
+  );
+  */
+  // #endif
   if (authorizationTabId == null) {
     throw new Error('failed to open the authorization tab');
   }

diff --git a/src/scripts/options/sync-section.tsx b/src/scripts/options/sync-section.tsx
@@ -414,18 +414,8 @@ const SyncCategories: React.VFC<{ disabled: boolean }> = ({ disabled }) => (
 export const SyncSection: React.VFC = () => {
   const {
     initialItems: { syncCloudId: initialSyncCloudId },
-    /* #if FIREFOX
-    platformInfo: { os },
-    */
-    // #endif
   } = useOptionsContext();
   const [syncCloudId, setSyncCloudId] = useState(initialSyncCloudId);
-  /* #if FIREFOX
-  if (os === 'android') {
-    return null;
-  }
-  */
-  // #endif
   return (
     <Section aria-labelledby="syncSectionTitle" id="sync">
       <SectionHeader>