fix: key positions for sort command

.github/workflows/release.yml

@@ -10,13 +10,15 @@ jobs:
   release:
     environment: Release
     runs-on: ubuntu-latest
+    needs: test
     steps:
       - uses: actions/checkout@v2
       - name: Use Node.js ${{ matrix.node-version }}
         uses: actions/setup-node@v2
         with:
           node-version: "lts/*"
       - run: npm ci
+      - run: npm run build
       - name: Release
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/test.yml

@@ -17,5 +17,7 @@ jobs:
           node-version: ${{ matrix.node-version }}
       - name: Install dependencies
         run: npm ci
+      - name: Build
+        run: npm run build
       - name: Test
         run: npm test

README.md

@@ -1,7 +1,5 @@
 # Redis Commands
 
-[![Build Status](https://github.com/ioredis/commands/actions/workflows/release.yml/badge.svg?branch=master)](https://github.com/ioredis/commands/actions/workflows/release.yml?query=branch%3Amain)
-
 This module exports all the commands that Redis supports.
 
 ## Install
@@ -19,7 +17,7 @@ const commands = require('@ioredis/commands');
 `.list` is an array contains all the lowercased commands:
 
 ```js
-commands.list.forEach(function (command) {
+commands.list.forEach((command) => {
   console.log(command);
 });
 ```

lib/index.ts

@@ -1,4 +1,4 @@
-import commands from "../commands.json";
+import commands from "./commands.json";
 
 /**
  * Redis command list
@@ -63,7 +63,7 @@ export function getKeyIndexes(
   }
 
   const keys = [];
-  const parseExternalKey = options && options.parseExternalKey;
+  const parseExternalKey = Boolean(options && options.parseExternalKey);
 
   switch (commandName) {
     case "zunionstore":
@@ -80,13 +80,14 @@ export function getKeyIndexes(
     case "sort":
       keys.push(0);
       for (let i = 1; i < args.length - 1; i++) {
-        const arg = args[i];
+        let arg = args[i];
         if (typeof arg !== "string") {
           continue;
         }
         const directive = arg.toUpperCase();
         if (directive === "GET") {
           i += 1;
+          arg = args[i];
           if (arg !== "#") {
             if (parseExternalKey) {
               keys.push([i, getExternalKeyNameLength(arg)]);
@@ -97,7 +98,7 @@ export function getKeyIndexes(
         } else if (directive === "BY") {
           i += 1;
           if (parseExternalKey) {
-            keys.push([i, getExternalKeyNameLength(arg)]);
+            keys.push([i, getExternalKeyNameLength(args[i])]);
           } else {
             keys.push(i);
           }

package.json

@@ -10,7 +10,7 @@
   "scripts": {
     "pretest": "npm run lint",
     "test": "mocha",
-    "build": "tsc",
+    "build": "rm -rf built && tsc",
     "gen": "node tools/build",
     "lint": "standard --fix --verbose | snazzy",
     "release": "release-it"