associations: use collections.abc instead of collections #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
force-pushed
the
collections-fix
branch
3 times, most recently
from
5330444
to
8e29765
Compare
|
Support for Python 2 has just been removed and the cli-tools are now supporting Python 3.7+. Please rebase. Maybe you could also add "3.10" in the GH action matrix ? |
Using or importing the ABCs from `collections` instead of from `collections.abc` is deprecated since Python 3.3, and in 3.10 it will stop working. Since Python 3.10 was released a few month ago, and starting to get deployed in operating systems such as Arch or Fedora, this should be fixed ASAP.
miri64
force-pushed
the
collections-fix
branch
from
8e29765
to
6826c41
Compare
Done and done. |
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using or importing the ABCs from
collectionsinstead of fromcollections.abcis deprecated since Python 3.3, and in 3.10 it will stop working. Since Python 3.10 was released a few month ago, and starting to get deployed in operating systems such as Arch or Fedora, this should be fixed ASAP.