Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement RFC42 - secret-debug-display #101

Merged
merged 3 commits into from
Jul 10, 2020
Merged

Implement RFC42 - secret-debug-display #101

merged 3 commits into from
Jul 10, 2020

Conversation

thibault-martinez
Copy link
Member

@thibault-martinez thibault-martinez commented Jul 10, 2020 •
edited
Loading

Description of change

Implement RFC42 - secret-debug-display

Links to any relevant issues

#100

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes
  • I have updated the CHANGELOG.md, if my changes are significant enough

@thibault-martinez thibault-martinez added c-feature Category - Feature e-high Experience - High p-medium Priority - Medium wg-signing Working Group - Signing labels Jul 10, 2020
@thibault-martinez thibault-martinez mentioned this pull request Jul 10, 2020
Closed
zesterer
zesterer previously approved these changes Jul 10, 2020
View reviewed changes
@samuel-rufi samuel-rufi self-requested a review July 10, 2020 08:42
wusyong
wusyong previously approved these changes Jul 10, 2020
View reviewed changes
samuel-rufi
samuel-rufi previously approved these changes Jul 10, 2020
View reviewed changes
Alex6323
Alex6323 requested changes Jul 10, 2020
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
bee-signing/bee-signing-derive/Cargo.toml Outdated Show resolved Hide resolved
bee-signing/bee-signing-derive/src/lib.rs Outdated Show resolved Hide resolved
bee-signing/bee-signing-derive/src/lib.rs Outdated Show resolved Hide resolved
@thibault-martinez thibault-martinez merged commit 4c84134 into iotaledger:master Jul 10, 2020
@thibault-martinez thibault-martinez deleted the bee-signing-derive branch March 16, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zesterer zesterer zesterer approved these changes

@wusyong wusyong wusyong approved these changes

@samuel-rufi samuel-rufi samuel-rufi approved these changes

@Alex6323 Alex6323 Alex6323 approved these changes

Assignees
No one assigned
Labels
c-feature Category - Feature e-high Experience - High p-medium Priority - Medium wg-signing Working Group - Signing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@thibault-martinez @zesterer @wusyong @samuel-rufi @Alex6323