Ternary big integers common parts #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibault-martinez
added
c-feature
Alex6323
requested changes
Jul 13, 2020
Alex6323
approved these changes
Jul 14, 2020
samuel-rufi
approved these changes
Jul 14, 2020
zesterer
reviewed
Jul 14, 2020
|
|
||
| impl OverflowingAdd for u32 { | ||
| fn overflowing_add_with_carry(self, other: Self, carry: Self) -> (Self, bool) { | ||
| let (sum, first_overflow) = self.overflowing_add(other); |
There was a problem hiding this comment.
I'm not entirely sure what the purpose of this code is, could you explain? I see that there's an add-plus-carry but I'm not sure what context this all might be useful in.
There was a problem hiding this comment.
I am not the author of the code but I'll try to explain.
When dealing with big integers you have a lot of carry propagation to handle. This piece of code is just an extension of the overflowing add with a carry. It could technically be done without this function but this is just to DRY things I assume.
zesterer
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adds common parts of ternary big integers.
Links to any relevant issues
Part of #77
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.