-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ternary big integers #107
Add ternary big integers #107
Conversation
6128a95
to
4010b77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a quite complex RFC, however from the perspective of the code - besides what Joshua and Alex noticed - it seems ok to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is one of the hardest to understand Bee crates so far, and I would need to really deep-dive into the details of it to fully grasp it. I have no doubt, that the code is correctly working as it's cross-checked with other implementations via unit-tests, but the code overall feels a bit over-engineered, and also not very DRY, although I am not sure, the repetitiveness could have been prevented here.
Description of change
Add ternary big integers.
Links to any relevant issues
#77
How the change has been tested
Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.