Add ternary cryptographic sponges #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibault-martinez
added
wg-crypto
samuel-rufi
reviewed
Jul 21, 2020
wusyong
reviewed
Jul 21, 2020
zesterer
reviewed
Jul 21, 2020
zesterer
reviewed
Jul 21, 2020
zesterer
reviewed
Jul 21, 2020
| } | ||
| } | ||
|
|
||
| impl<T: Sponge, U: DerefMut<Target = T>> Sponge for U { |
There was a problem hiding this comment.
Is this necessary? Uses of this impl could just borrow &mut foo and Rust's dereference coercion should do the rest.
There was a problem hiding this comment.
This is necessary for CurlP27 and CurlP81 that are wrappers of CurlP implementing Deref.
pvdrz
reviewed
Jul 21, 2020
pvdrz
reviewed
Jul 21, 2020
Alex6323
requested changes
Jul 22, 2020
zesterer
previously approved these changes
Jul 22, 2020
Alex6323
previously approved these changes
Jul 22, 2020
wusyong
previously approved these changes
Jul 23, 2020
samuel-rufi
previously approved these changes
Jul 23, 2020
thibault-martinez
dismissed stale reviews from samuel-rufi, wusyong, Alex6323, and zesterer
via
28502a2
wusyong
approved these changes
Jul 23, 2020
Alex6323
approved these changes
Jul 23, 2020
samuel-rufi
approved these changes
Jul 23, 2020
zesterer
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Add ternary cryptographic sponges
Links to any relevant issues
#77
How the change has been tested
Added tests.
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.