New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check storage deposit for `Output`s #1176

Merged

thibault-martinez merged 29 commits into iotaledger:shimmer-develop from grtlr:shimmer-check-storage-deposit

Mar 9, 2022

Contributor

grtlr commented Feb 25, 2022

Description of change

Dust protection ✨.

Links to any relevant issues

Closes #1104.

Type of change

Choose a type of change, and delete any options that are not relevant.

Enhancement (a non-breaking change which adds functionality)

How the change has been tested

At some point we should think about how to the whole storage deposit logic. @thibault-martinez any ideas on that?

Change checklist

I have followed the contribution guidelines for this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
I have checked that new and existing unit tests pass locally with my changes
I have updated the CHANGELOG.md, if my changes are significant enough

grtlr requested review from thibault-martinez and samuel-rufi as code owners

February 25, 2022 08:08

grtlr linked an issue

that may be closed by this pull request

Add syntactic ByteCost checks #1104

Closed

grtlr force-pushed the shimmer-check-storage-deposit branch from bcd03b4 to c2a73fa Compare

February 25, 2022 09:55

pvdrz previously approved these changes

View reviewed changes

grtlr dismissed pvdrz’s stale review via

4d6115a

February 28, 2022 16:26

grtlr force-pushed the shimmer-check-storage-deposit branch from cc52bb0 to 4d6115a Compare

February 28, 2022 16:26

pvdrz previously approved these changes

View reviewed changes

grtlr dismissed pvdrz’s stale review via

2d6029a

February 28, 2022 18:44

pvdrz approved these changes

View reviewed changes

pvdrz previously approved these changes

View reviewed changes

grtlr dismissed pvdrz’s stale review via

6a168e1

March 1, 2022 16:35

grtlr requested a review from bingyanglin as a code owner

March 1, 2022 16:35

Thoralf-M reviewed

View reviewed changes

bee-message/src/error.rs Outdated Show resolved Hide resolved

thibault-martinez reviewed

View reviewed changes

bee-message/src/output/mod.rs Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

bee-message/src/output/mod.rs Outdated Show resolved Hide resolved

grtlr force-pushed the shimmer-check-storage-deposit branch from 5bb09b3 to 28ecfb7 Compare

March 2, 2022 09:59

Thoralf-M reviewed

View reviewed changes

bee-message/src/output/mod.rs Outdated Show resolved Hide resolved

grtlr force-pushed the shimmer-check-storage-deposit branch from 0290fdd to e4837d0 Compare

March 3, 2022 07:25

grtlr added this to the v1.0 milestone

Thoralf-M reviewed

View reviewed changes

bee-message/src/output/mod.rs Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

bee-message/src/error.rs Outdated Show resolved Hide resolved

grtlr changed the title ~~Check minimum_storage_deposit for Outputs~~ Check storage deposit for Outputs

Thoralf-M reviewed

View reviewed changes

bee-message/src/output/mod.rs Outdated Show resolved Hide resolved

thibault-martinez reviewed

View reviewed changes

bee-message/src/output/mod.rs Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

bee-message/src/output/mod.rs Outdated Show resolved Hide resolved

Thoralf-M previously approved these changes

View reviewed changes

grtlr dismissed Thoralf-M’s stale review via

269f343

March 7, 2022 14:08

grtlr force-pushed the shimmer-check-storage-deposit branch from bae7eec to 269f343 Compare

March 7, 2022 14:08

Thoralf-M previously approved these changes

View reviewed changes

grtlr added 23 commits

March 9, 2022 16:36


          Move tests

8c3fb60


          Format

1724e84


          Better Error types

9e51c44


          Unify comparisons

01a765f


          Return InsufficientStorageAmount if both are wrong

f6e4bff


          Shorten

abe2eff


          Typo

05f12f1


          Thanks clippy 😊

12c55c3


          Swap order of deposit and required

71a245c


          Check bounds of StorageDepositReturnAmount

ca135df


          Wording

d08a006


          Fix storage deposit check

9f55f67

Fmt

afff902


          Better error messages

4df1c5f


          Style

87cf6c7

Fmt

927c3dc


          Rename remainder -> logical_amount

7eed093


          Properly applying the byte_cost to the offset

2d1df38


          Address comments

57f4024


          Rename torequired_output_amount

8839ae8


          Update CHANGELOG.md

6e4fb03


          Fix clippy

81c66a5


          Fix docs

e4743fa

grtlr dismissed stale reviews from thibault-martinez and Thoralf-M via

e4743fa

March 9, 2022 15:36

grtlr force-pushed the shimmer-check-storage-deposit branch from bc06775 to e4743fa Compare

March 9, 2022 15:36

thibault-martinez approved these changes

View reviewed changes

pvdrz approved these changes

View reviewed changes

Thoralf-M approved these changes

View reviewed changes

thibault-martinez merged commit c39fc86 into iotaledger:shimmer-develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

thibault-martinez thibault-martinez approved these changes

pvdrz pvdrz approved these changes

Thoralf-M Thoralf-M approved these changes

samuel-rufi Awaiting requested review from samuel-rufi samuel-rufi is a code owner

bingyanglin Awaiting requested review from bingyanglin