Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shutdown mechanism to bee-common crate #97

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Add shutdown mechanism to bee-common crate #97

merged 1 commit into from
Jul 8, 2020

Conversation

Alex6323
Copy link
Contributor

@Alex6323 Alex6323 commented Jul 6, 2020

Description of change

Please write a summary of your changes and why you made them.

Links to any relevant issues

Be sure to reference any related issues by adding fixes issue #.

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

bee-common/src/shutdown.rs Outdated Show resolved Hide resolved
bee-common/src/shutdown.rs Outdated Show resolved Hide resolved
bee-common/src/shutdown.rs Outdated Show resolved Hide resolved
bee-common/src/shutdown.rs Show resolved Hide resolved
bee-common/src/worker.rs Outdated Show resolved Hide resolved
Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a line in the CHANGELOG so that we don't forget please ?
Add shutdown mechanism should be enough :)

samuel-rufi
samuel-rufi previously approved these changes Jul 7, 2020
zesterer
zesterer previously approved these changes Jul 8, 2020
@Alex6323 Alex6323 merged commit 371700c into iotaledger:master Jul 8, 2020
@Alex6323 Alex6323 deleted the feat/shutdown branch July 8, 2020 10:43
Alex6323 pushed a commit to Alex6323/bee that referenced this pull request Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants