auth-helper: allow for tokens without expiry
#11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 25, 2022 15:18
samuel-rufi
previously approved these changes
Jan 25, 2022
samuel-rufi
previously approved these changes
Jan 25, 2022
added 3 commits
January 26, 2022 17:12
thibault-martinez
previously approved these changes
Jan 26, 2022
Adam-Gleave
added
enhancement
c-enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few new changes to obey closer to the JWT spec, and allows us to create tokens without an expiry timestamp. Also allows the field to be ignored during validation (because it will not exist). This could possibly be extended with other optional fields defined in the RFC in the future.