Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the packable and packable-derive crates #2

Merged
merged 20 commits into from
Jan 14, 2022
Merged

Add the packable and packable-derive crates #2

merged 20 commits into from
Jan 14, 2022

Conversation

pvdrz
Copy link
Contributor

@pvdrz pvdrz commented Jan 13, 2022

No description provided.

thibault-martinez
thibault-martinez reviewed Jan 13, 2022
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
grtlr
grtlr suggested changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@grtlr grtlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope the code stayed the same from our last review because I only looked at the project related files. Just let me know if I should also review particular parts of the code. 😅

packable/packable-derive/README.md Outdated Show resolved Hide resolved
packable/packable/README.md Show resolved Hide resolved
packable/packable/Cargo.toml Outdated Show resolved Hide resolved
Adam-Gleave
Adam-Gleave reviewed Jan 14, 2022
View reviewed changes
Copy link
Contributor

@Adam-Gleave Adam-Gleave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to tell me I'm being too picky :trollface:

packable/packable-derive/Cargo.toml Outdated Show resolved Hide resolved
packable/packable/src/error.rs Outdated Show resolved Hide resolved
packable/packable/src/packable/array.rs Outdated Show resolved Hide resolved
thibault-martinez
thibault-martinez previously approved these changes Jan 14, 2022
View reviewed changes
packable/packable-derive/README.md Show resolved Hide resolved
@pvdrz pvdrz closed this Jan 14, 2022
@pvdrz pvdrz reopened this Jan 14, 2022
@pvdrz pvdrz closed this Jan 14, 2022
@pvdrz pvdrz reopened this Jan 14, 2022
@thibault-martinez thibault-martinez merged commit 5c65eae into iotaledger:main Jan 14, 2022
@pvdrz pvdrz deleted the packable branch January 14, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibault-martinez thibault-martinez thibault-martinez left review comments

@Adam-Gleave Adam-Gleave Adam-Gleave left review comments

@grtlr grtlr grtlr requested changes

@samuel-rufi samuel-rufi Awaiting requested review from samuel-rufi

@Alex6323 Alex6323 Awaiting requested review from Alex6323

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pvdrz @thibault-martinez @grtlr @Adam-Gleave