Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Expired Assets on Address Page #1394

Merged
merged 5 commits into from
Apr 19, 2024
Merged

Fix: Expired Assets on Address Page #1394

merged 5 commits into from
Apr 19, 2024

Conversation

brancoder
Copy link
Collaborator

Remove assets from Address Page if expiration time has passed and show them on the Address page for the expirationReturnAddress

closes #594

Description of change

Please write a summary of your changes and why you made them. Be sure to reference any related issues by adding fixes # (issue).

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Native tokens can be tested on shimmer using the address smr1qqe0adqtuyz2pg4gqf37cu9w0d4znj4dejzz6svw3fhtsmgw08j3g4pgs5a from the task #594

Nfts can be tested on Testnet using this output that has expiration unlock condition that has passed: 0xec58cc5a805e979cef0d4e62553957ce43a18c221682d2abf34df91ed0d313e20000

Change checklist

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@brancoder brancoder merged commit d1eee50 into main Apr 19, 2024
6 checks passed
@brancoder brancoder deleted the fix/expired-assets branch April 19, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Expired Native tokens
2 participants