Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove lazy App import #1465

Merged
merged 3 commits into from
May 7, 2024
Merged

fix: remove lazy App import #1465

merged 3 commits into from
May 7, 2024

Conversation

VmMad
Copy link
Member

@VmMad VmMad commented May 7, 2024

Description of change

Fixes #1460

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Run the client in preview mode npm run build && npm run preview and access with the basic access auth in the url. It will have the same behavior as in the deployed version. Try this with and without the fix.

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Collaborator

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work 🎊 LGTM

@begonaalvarezd begonaalvarezd merged commit 172d196 into main May 7, 2024
6 checks passed
@begonaalvarezd begonaalvarezd deleted the fix/lazy-app-import branch May 7, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Fix crashed explorer with basic auth
3 participants