Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow InfluxService to be registered without 'initial ping' #1468

Merged
merged 3 commits into from
May 8, 2024
Merged

fix: Allow InfluxService to be registered without 'initial ping' #1468

merged 3 commits into from
May 8, 2024

Conversation

msarcev
Copy link
Collaborator

@msarcev msarcev commented May 7, 2024 •
edited by begonaalvarezd

Description of change

Type of change

  • Enhancement (a non-breaking change which adds functionality)

@msarcev
fix: Allow InfluxService to be registered without 'initial ping' depe…
2ca15a0 
…ndency (if it's configured we assume it works and register)
brancoder
brancoder approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@begonaalvarezd begonaalvarezd merged commit 0289727 into main May 8, 2024
12 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/remove-influx-ping-dependency-for-influx-service branch May 8, 2024 11:21
@begonaalvarezd begonaalvarezd mentioned this pull request May 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brancoder brancoder brancoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Improve InfluxService initialization
3 participants
@msarcev @brancoder @begonaalvarezd