fix: voting with same answers (#5674)

* fix: add simple fix

* fix: allow switching single answer

* chore: revert line

* chore: adjust logic and reduce code

* fix: adjust logic if not voted yet

* chore: add explanative comments

Co-authored-by: Mark Nardi <mark.nardi@iota.org>
Co-authored-by: MarkNerdi <105642810+MarkNerdi@users.noreply.github.com>

packages/desktop/views/dashboard/governance/views/DetailsView.svelte

@@ -26,7 +26,7 @@
         selectedProposal,
         updateParticipationOverview,
     } from '@contexts/governance/stores'
-    import { calculateWeightedVotes } from '@contexts/governance/utils'
+    import { calculateWeightedVotes, getActiveParticipation } from '@contexts/governance/utils'
     import { getBestTimeDuration, milestoneToDate } from '@core/utils'
     import { networkStatus } from '@core/network/stores'
     import { formatTokenAmountBestMatch } from '@core/wallet/utils'
@@ -57,17 +57,39 @@
     $: questions = votingPayload?.questions
 
     $: if (questions?.length > 0 && selectedAnswerValues?.length === 0) {
-        selectedAnswerValues = Array<number>(questions?.length)
+        selectedAnswerValues =
+            getActiveParticipation($selectedProposal?.id)?.answers ?? Array<number>(questions?.length)
     }
+
     $: isVotingDisabled =
         proposalState?.status === ProposalStatus.Upcoming ||
         proposalState?.status === ProposalStatus.Ended ||
         selectedAnswerValues?.length === 0 ||
-        selectedAnswerValues?.includes(undefined)
+        selectedAnswerValues?.includes(undefined) ||
+        !hasChangedAnswers(selectedAnswerValues)
 
     $: isTransferring = $selectedAccount?.isTransferring
     $: proposalState, (voteButtonText = getVoteButtonText())
 
+    function hasChangedAnswers(_selectedAnswerValues: number[]): boolean {
+        const activeParticipationAnswerValues = getActiveParticipation($selectedProposal?.id)?.answers
+        if (activeParticipationAnswerValues) {
+            /**
+             * NOTE: If any of the values between what's active and selected differ, it means
+             * that the user has changed at least one answer.
+             */
+            return _selectedAnswerValues.some(
+                (selectedAnswerValue, idx) => selectedAnswerValue !== activeParticipationAnswerValues[idx]
+            )
+        } else {
+            /**
+             * NOTE: If the user hasn't voted for the participation yet, the user has not changed (all) answers
+             * yet until every value is not undefined.
+             */
+            return _selectedAnswerValues.every((selectedAnswerValue) => selectedAnswerValue !== undefined)
+        }
+    }
+
     async function setVotingEventPayload(eventId: string): Promise<void> {
         const event = await getVotingEvent(eventId)
         if (event?.data?.payload?.type === ParticipationEventType.Voting) {
@@ -103,7 +125,14 @@
 
     function handleQuestionClick(event: CustomEvent): void {
         const { questionIndex } = event.detail
-        openedQuestionIndex = openedQuestionIndex === questionIndex ? null : questionIndex
+        openedQuestionIndex = questionIndex
+
+        const selectedQuestionElement: HTMLElement = proposalQuestions?.querySelector(
+            'proposal-question:nth-child(' + openedQuestionIndex + ')'
+        )
+        setTimeout(() => {
+            proposalQuestions.scrollTo({ top: selectedQuestionElement?.offsetTop, behavior: 'smooth' })
+        }, 250)
     }
 
     function handleCancelClick(): void {
@@ -119,19 +148,7 @@
 
     function handleAnswerClick(event: CustomEvent): void {
         const { answerValue, questionIndex } = event.detail
-        if (selectedAnswerValues[questionIndex] === answerValue) {
-            selectedAnswerValues[questionIndex] = null
-        } else {
-            selectedAnswerValues[questionIndex] = answerValue
-        }
-
-        openedQuestionIndex = selectedAnswerValues.length === questionIndex + 1 ? null : questionIndex + 1
-        const selectedQuestionElement: HTMLElement = proposalQuestions?.querySelector(
-            'proposal-question:nth-child(' + (openedQuestionIndex + 1) + ')'
-        )
-        setTimeout(() => {
-            proposalQuestions.scrollTo({ top: selectedQuestionElement?.offsetTop, behavior: 'smooth' })
-        }, 250)
+        selectedAnswerValues[questionIndex] = answerValue
     }
 
     function getVoteButtonText(): string {

packages/shared/lib/contexts/governance/utils/getActiveParticipation.ts

@@ -0,0 +1,13 @@
+import { get } from 'svelte/store'
+
+import { EventId, TrackedParticipationOverview } from '@iota/wallet'
+
+import { participationOverview } from '../stores'
+
+export function getActiveParticipation(proposalId: EventId): TrackedParticipationOverview {
+    const overview = get(participationOverview)
+    const participationsForProposal: TrackedParticipationOverview[] = Object.values(
+        overview?.participations?.[proposalId] ?? {}
+    )
+    return participationsForProposal.find((participation) => participation?.endMilestoneIndex === 0)
+}

packages/shared/lib/contexts/governance/utils/index.ts

@@ -1,5 +1,6 @@
 export * from './calculateWeightedVotes'
 export * from './createProposalsFromEvents'
+export * from './getActiveParticipation'
 export * from './getNumberOfActiveProposals'
 export * from './getNumberOfTotalProposals'
 export * from './getNumberOfVotedProposals'