Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Refactor market module #3976

Closed
4 tasks done
maxwellmattryan opened this issue Jul 21, 2022 · 0 comments · Fixed by #4992
Closed
4 tasks done

[Task]: Refactor market module #3976

maxwellmattryan opened this issue Jul 21, 2022 · 0 comments · Fixed by #4992
Assignees
@maxwellmattryan
Labels
stardust Related to the Stardust Protocol type:refactor Refactor code
Milestone
E00.M1 - Stardust...

Comments

@maxwellmattryan
Copy link
Contributor

maxwellmattryan commented Jul 21, 2022 •
edited

Task description

The existing logic for polling market data needs to be moved to a new market module in lib/auxiliary/market.

Requirements

  • Remove market module as no code is used

Creation checklist

  • I have assigned this task to the correct people
  • I have added the most appropriate labels
  • I have linked the correct milestone and/or project
@maxwellmattryan maxwellmattryan added type:refactor Refactor code stardust Related to the Stardust Protocol labels Jul 21, 2022
@maxwellmattryan maxwellmattryan self-assigned this Oct 18, 2022
@maxwellmattryan maxwellmattryan mentioned this issue Oct 19, 2022
Merged
12 tasks
@maxwellmattryan maxwellmattryan linked a pull request Oct 19, 2022 that will close this issue
refactor: market module #4992
Merged
12 tasks
@maxwellmattryan maxwellmattryan changed the title [Task]: Refactor market auxiliary module [Task]: Refactor market module Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxwellmattryan maxwellmattryan

Labels
stardust Related to the Stardust Protocol type:refactor Refactor code
Projects
Firefly - Task Management
Archived in project
Milestone
E00.M1 - Stardust Backlog
Development

Successfully merging a pull request may close this issue.

refactor/market-module iotaledger/firefly
refactor: market module iotaledger/firefly
1 participant
@maxwellmattryan