Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: market module #4992

Merged
merged 3 commits into from Oct 20, 2022
Merged

refactor: market module #4992

merged 3 commits into from Oct 20, 2022

Conversation

maxwellmattryan
Copy link
Contributor

Summary

Please summarize your changes, describing what they are and why they were made.

This PR removes market-related code as it is unused and has been for a long time. It is likely any future market data fetching will be re-written anyway.

Changelog

- Remove lib and type files for market

Relevant Issues

Please list any related issues using development keywords.

Closes #3976

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

Test that switching currency still works.

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@maxwellmattryan maxwellmattryan added type:refactor Refactor code stardust Related to the Stardust Protocol labels Oct 19, 2022
@maxwellmattryan maxwellmattryan self-assigned this Oct 19, 2022
@maxwellmattryan maxwellmattryan linked an issue Oct 19, 2022 that may be closed by this pull request
4 tasks
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firefly didn't compile due to market.ts being imported in helpers.ts. I removed the relevant code parts, but let's get this merged, so that it doesn't go down the same path as the other refactors :D

@Tuditi Tuditi merged commit 522012a into stardust-develop Oct 20, 2022
@Tuditi Tuditi deleted the refactor/market-module branch October 20, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stardust Related to the Stardust Protocol type:refactor Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Refactor market module
2 participants