Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Correctly determine when metadata should be parsed as an L2 transaction #5416

Closed
3 tasks done
Tuditi opened this issue Dec 13, 2022 · 0 comments · Fixed by #5421
Closed
3 tasks done

[Task]: Correctly determine when metadata should be parsed as an L2 transaction #5416

Tuditi opened this issue Dec 13, 2022 · 0 comments · Fixed by #5421
Assignees
@Tuditi
Labels
context:governance stardust Related to the Stardust Protocol type:enhancement Enhancement to existing feature
Milestone
E13.M1 - L1 -> L2

Comments

@Tuditi
Copy link
Contributor

Tuditi commented Dec 13, 2022

Task description

Currently, governance votes cause an error, since the answers are encoded in an array, which are not necessarily ASCII characters. This means that it gets picked up as a L2 transaction and is parsed as such, which fails, since it's not an L2 tx.

Requirements

TBD

Creation checklist

  • I have assigned this task to the correct people
  • I have added the most appropriate labels
  • I have linked the correct milestone and/or project
@Tuditi Tuditi added type:enhancement Enhancement to existing feature context:governance stardust Related to the Stardust Protocol labels Dec 13, 2022
@Tuditi Tuditi added this to the E13.M1 - L1 -> L2 milestone Dec 13, 2022
@Tuditi Tuditi self-assigned this Dec 13, 2022
@Tuditi Tuditi mentioned this issue Dec 14, 2022
Merged
12 tasks
@Tuditi Tuditi linked a pull request Dec 14, 2022 that will close this issue
fix: correctly decide on parsing l2 #5421
Merged
12 tasks
@Tuditi Tuditi closed this as completed Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tuditi Tuditi

Labels
context:governance stardust Related to the Stardust Protocol type:enhancement Enhancement to existing feature
Projects
Firefly - Task Management
Archived in project
Milestone
E13.M1 - L1 -> L2
Development

Successfully merging a pull request may close this issue.

fix: correctly decide on parsing l2 iotaledger/firefly
1 participant
@Tuditi