Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly decide on parsing l2 #5421

Merged
merged 3 commits into from Dec 15, 2022

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Dec 14, 2022

Summary

Improves the way metadata is parsed by taking into account the sender account for L2 transfers and control characters being present in the bytes.
...

Changelog

- extracted containsControlCharacters from validation function
- improved metadata decoding

Relevant Issues

closes: #5416

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@Tuditi Tuditi self-assigned this Dec 14, 2022
@Tuditi Tuditi force-pushed the fix/correctly-decide-on-parsing-L2 branch from 5152217 to e61ce81 Compare December 14, 2022 14:56
@Tuditi Tuditi linked an issue Dec 14, 2022 that may be closed by this pull request
3 tasks
@Tuditi Tuditi marked this pull request as ready for review December 14, 2022 14:59
@Tuditi Tuditi force-pushed the fix/correctly-decide-on-parsing-L2 branch 2 times, most recently from 65f9dc3 to 64e45f9 Compare December 14, 2022 15:17
@Tuditi Tuditi force-pushed the fix/correctly-decide-on-parsing-L2 branch from 64e45f9 to e8c5cb6 Compare December 14, 2022 15:21
Copy link
Contributor

@maxwellmattryan maxwellmattryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@Tuditi Tuditi merged commit 3829ee3 into stardust-develop Dec 15, 2022
@Tuditi Tuditi deleted the fix/correctly-decide-on-parsing-L2 branch December 15, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Correctly determine when metadata should be parsed as an L2 transaction
2 participants