Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-integers accepted as PIN by copy-paste #772

Closed
ATimesThree opened this issue Mar 29, 2021 · 1 comment
Closed

Non-integers accepted as PIN by copy-paste #772

ATimesThree opened this issue Mar 29, 2021 · 1 comment
Labels
bug report Something isn't working as intended

Comments

@ATimesThree
Copy link

Issue description

PIN can be set to all kind of characters if pasted. Only keypress is blocked.

Wallet version

v0.3.1

System specification

Win10 Pro, 20H2.

Is it a repeatable issue?

Y

Steps To reproduce the issue

FireFly_PIN-Copy-Paste_ATimesThree.mp4

Expected behaviour

  1. Check on leave if field contains non-accepted characters.
  2. Set field to blank or PIN change not possible if non-accepted exist.

Actual behaviour

Allows the PIN to be changed.

Errors

None.
@ATimesThree ATimesThree added the bug report Something isn't working as intended label Mar 29, 2021
@obany obany mentioned this issue Mar 30, 2021
Merged
6 tasks
@obany
Copy link
Contributor

obany commented Mar 30, 2021

This will be fixed in the next build, the settings page uses the PIN input control, see #609

@obany obany closed this as completed Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug report Something isn't working as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@obany @ATimesThree