Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: JWT auth #1218

Merged
merged 3 commits into from
Jun 22, 2021
Merged

fix: JWT auth #1218

merged 3 commits into from
Jun 22, 2021

Conversation

maxwellmattryan
Copy link
Contributor

@maxwellmattryan maxwellmattryan commented Jun 21, 2021

Description of change

To keep up with changes involving node authentication in wallet.rs, it's necessary to change the type definitions and others relevant parts of the internal library.

Links to any relevant issues

No issue

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Tested on:

  • Ubuntu (20.04)
  • MacOS (Catalina 10.15.7)

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation

@@ -149,7 +150,6 @@ export type MessageResponse =
| SetAliasResponse
| DeleteStorageResponse
| LockStrongholdResponse
| StrongholdStatusResponse
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line was removed because it was a duplicate - see line #146.

@maxwellmattryan maxwellmattryan marked this pull request as ready for review June 21, 2021 21:31
@cvarley100 cvarley100 merged commit 80aa2da into develop Jun 22, 2021
@cvarley100 cvarley100 deleted the fix/jwt-auth branch June 22, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants