Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Ledger Nano support #1373

Merged
merged 275 commits into from
Aug 5, 2021
Merged

feat: add Ledger Nano support #1373

merged 275 commits into from
Aug 5, 2021

Conversation

cvarley100
Copy link
Contributor

Description of change

This PR adds Ledger nano support and removes the dev environment set up in feat/ledger.

Type of change

  • New (a change which implements a new feature)

How the change has been tested

Tested extensively over a 3 month period.

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

lucasfernog and others added 30 commits February 24, 2021 20:48
@lucasfernog
refactor: rename accountType to profileType
6b88133
@lucasfernog
fix: client options on firefly import
f7ccb88
@lucasfernog
fix: no need to save profile on ledger, it's saved on Congratulations
17b531f
@lucasfernog
feat: do not check stronghold status on ledger profile
18e1534
@lucasfernog
fix: ledger import goes to Protect (set PIN) route
85413e2
@lucasfernog
feat(dashboard): add Locked label
817ec32
@lucasfernog
Merge remote-tracking branch 'origin/develop' into feat/ledger
cf7b776
@lucasfernog
fix(router): ledger setup router
7ffd8de
@lucasfernog
Merge branch 'develop' into feat/ledger
bff927c
@lucasfernog
Merge branch 'develop' into feat/ledger
ab7ca3b
@lucasfernog
Merge branch 'develop' into feat/ledger
ff65346
@begonaalvarezd
Merge remote-tracking branch 'origin/develop' into feat/ledger-premerge
80754d7
@begonaalvarezd
fix imports
7d6e421
@begonaalvarezd
wip update ledger views
49998f5
@begonaalvarezd
fix import
841d7a2
@laumair
chore: resolve remaining merge conflicts
4ee2917
@begonaalvarezd
wip update ledger views
5209501
@begonaalvarezd
Merge branch 'feat/ledger-premerge' of github.com:iotaledger/new-wall…
b7b7421 
…et into feat/ledger-premerge
@begonaalvarezd
Update ledger views
8326d00
@begonaalvarezd
add comment
0088ade
@begonaalvarezd
Update Ledger popup style
47c266f
@begonaalvarezd
Add missing break in route to prevent ledger getting into password flows
2b3c5e9
@begonaalvarezd
Update locales
3191b9a
@begonaalvarezd
add missing imports to wallet.svelte
11fdf13
@begonaalvarezd
Update ledger popup handler
dbd542c
@begonaalvarezd
Rename ConfirmBalance file to Balance
b98c096
@begonaalvarezd
Update ledger balance ui
dca992a
@begonaalvarezd
Update import success
164eb9c
@begonaalvarezd
Reorder ledger import view files
bd73a82
@begonaalvarezd
wip trinity ledger views
d867700
cvarley100 and others added 26 commits August 2, 2021 22:07
@cvarley100
fix: simplify ledger status polling (#1343)
a731fa0 
* fix: simplify ledger status polling system

* fix: ensure correct poll function is used to initiate polling
@cvarley100
chore: update backend
8eb9fd4
@maxwellmattryan @cvarley100
fix: Undefined migration inputs (#1355)
addcbb0 
* fix: Add notification for missing bundle data

* chore: fix formatting

Co-authored-by: Charlie Varley <charlie.varley@iota.org>
@cvarley100
fix: ensure correct bundle is selected with multiple mines (#1356)
accbc36
@maxwellmattryan
fix: Correct string for creating first profiles
af32348
@cvarley100
fix: add missing video string
3af873e
hotfix: correctly set busy state during migration (#1358)
cad11dd
@begonaalvarezd
Feat: add final ledger video (#1360)
93b7d41 
* add final ledger video url

* Remove video outline
@github-actions @crowdin-bot
New Crowdin translations by Github Action (#1359)
e015011 
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
@cvarley100
chore: resolve conflicts
eee863c
@cvarley100
fix: add correct bundle mining timeout
a633cca
@cvarley100
fix: update to mainnet nodes
0fe8b66
@cvarley100
fix: remove ledger account index offset
8dfe6da
@cvarley100
fix: disable dev tools in production and remove menu item
a8c15b3
@laumair
chore: update default network name
c2b058e
@laumair
chore: update backend
325d973 
Includes: iotaledger/wallet.rs#725
@laumair
chore: update backend
bd0461f 
Points to iotaledger/wallet.rs@ef2a2fe
hotfix: ensure error notification is displayed on account creation (#…
6d237f0 
…1369)
@laumair
Merge remote-tracking branch 'upstream/feat/ledger' into release/fire…
b84ecf7 
…fly-1.2.0
@cvarley100
chore: resolve conflicts
076cdf9
@cvarley100
Merge branch 'feat/ledger' into release/firefly-1.2.0
8682c75
@begonaalvarezd
Feat: update ledger video (#1370)
e10b45f 
* update ledger video

* add new ledger video url to electron whitelist
@cvarley100
chore: resolve conflicts
16555da
@cvarley100
Merge branch 'feat/ledger' into release/firefly-1.2.0
6a48929
@rajivshah3
Fix translations
ac229ae
@rajivshah3
Fix Slovak translation
35b914c
@cvarley100 cvarley100 merged commit d3d21b2 into develop Aug 5, 2021
@cvarley100 cvarley100 deleted the release/firefly-1.2.0 branch August 5, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajivshah3 rajivshah3 rajivshah3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@cvarley100 @rajivshah3 @lucasfernog @begonaalvarezd @laumair @maxwellmattryan @Thoralf-M