Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Setup backup loader #367

Merged
merged 17 commits into from
Mar 11, 2021
Merged

fix: Setup backup loader #367

merged 17 commits into from
Mar 11, 2021

Conversation

obany
Copy link
Contributor

@obany obany commented Mar 10, 2021

Description of change

Fixes a number of issue around profile creation, adds busy indicators where necessary and improves mnemonic validation.

Links to any relevant issues

Fixes #358 #361 #355 #305

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Tested on windows, mac and ubuntu

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@obany obany requested a review from cvarley100 as a code owner March 10, 2021 10:42
@cvarley100
Copy link
Contributor

Screenshot 2021-03-11 at 01 21 22

I can't click on duplicate words.

Also I would just label the button "reset" and only turn it blue after a word has been selected.

@obany
Copy link
Contributor Author

obany commented Mar 11, 2021

Fixed, reset button label and only active after a selection. Duplicate words now allowed.

@cvarley100 cvarley100 merged commit 94bd868 into develop Mar 11, 2021
@cvarley100 cvarley100 deleted the fix/setup-backup-loader branch March 11, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mnemonic Check accepts everything
2 participants