Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove settings from native menu when logged out #388

Merged
merged 2 commits into from Mar 11, 2021

Conversation

obany
Copy link
Contributor

@obany obany commented Mar 11, 2021

Description of change

Removes the settings entry from native menu when logged out, at the moment it doesn't make sense to keep this menu entry when logged out as all the setting are stored in the active profile.

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Tested on windows

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@obany obany requested a review from cvarley100 as a code owner March 11, 2021 09:52
@cvarley100 cvarley100 merged commit 3db6b9d into develop Mar 11, 2021
@cvarley100 cvarley100 deleted the fix/native-menu-settings branch March 11, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants