Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add notification on copied to clipboard #434

Merged
merged 5 commits into from Mar 12, 2021

Conversation

begonaalvarezd
Copy link
Member

Description of change

Add app notification when something gets copied to the clipboard
Note: code depends on #433

Links to any relevant issues

Fixes #342(point 6), #417

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Electron Linux

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@begonaalvarezd begonaalvarezd changed the title Feat/clipboard notification Feat: add notification on copied to clipboard Mar 12, 2021
@begonaalvarezd begonaalvarezd marked this pull request as ready for review March 12, 2021 14:10
@cvarley100 cvarley100 merged commit 331c84c into develop Mar 12, 2021
@cvarley100 cvarley100 deleted the feat/clipboard-notification branch March 12, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some minor user experience issues list
3 participants